Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] random_utils.py to _signed_to_unsigned #739

Merged
merged 6 commits into from
Mar 28, 2024
Merged

[fix] random_utils.py to _signed_to_unsigned #739

merged 6 commits into from
Mar 28, 2024

Conversation

tfaod
Copy link
Contributor

@tfaod tfaod commented Mar 28, 2024

When running the submission_runner on the self-tuning track, we run into this error calling _signed_to_unsigned from random_utils.py.

I've added a fix

    rng = prng.PRNGKey(rng_seed)
  File "/private/home/axyang/optimization/algorithmic-efficiency-entry/algorithm
ic_efficiency/random_utils.py", line 79, in PRNGKey
    return _PRNGKey(seed)

priyakasimbeg and others added 6 commits March 26, 2024 10:34
When running the submission_runner on the self-tuning track, we run into this error calling `_signed_to_unsigned` from random_utils.py. 

I've added a fix

```ValueError: Seed must be between 0 and 2**32 - 1
    rng = prng.PRNGKey(rng_seed)
  File "/private/home/axyang/optimization/algorithmic-efficiency-entry/algorithm
ic_efficiency/random_utils.py", line 79, in PRNGKey
    return _PRNGKey(seed)
```
@tfaod tfaod requested a review from a team as a code owner March 28, 2024 19:48
@tfaod
Copy link
Contributor Author

tfaod commented Mar 28, 2024

Error comes from the following line in the self-tuning infra:

rng = prng.PRNGKey(rng_seed)

And crashes function score_submission_on_workload before training can start

@priyakasimbeg priyakasimbeg changed the base branch from main to dev March 28, 2024 19:55
Copy link
Contributor

@priyakasimbeg priyakasimbeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the fix!

@priyakasimbeg priyakasimbeg merged commit 44655cc into mlcommons:dev Mar 28, 2024
32 of 36 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants