Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat default dropout in doc #806

Merged
merged 10 commits into from
Dec 4, 2024

Conversation

init-22
Copy link

@init-22 init-22 commented Oct 31, 2024

Adding default dropout values for each workloads mentioned in this issue: #786

@init-22 init-22 requested a review from a team as a code owner October 31, 2024 17:25
Copy link

github-actions bot commented Oct 31, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@init-22
Copy link
Author

init-22 commented Nov 2, 2024

recheck

@priyakasimbeg priyakasimbeg changed the base branch from main to dev November 14, 2024 18:19
priyakasimbeg
priyakasimbeg previously approved these changes Nov 14, 2024
@priyakasimbeg
Copy link
Contributor

Hi Isaac, thanks for this PR. Looks great.
Can we remove cifar10 and mnist from the table? Those two are implemented more for testing purposes and aren't part of the 8 AlgoPerf benchmarking workloads.

@priyakasimbeg
Copy link
Contributor

Also, can you sign the CLA with the email address you use for your github account so that the CLA check passes.
If it still does not pass, could you email [email protected] and ask for help with the CLA check in this PR.

@morphine00
Copy link
Contributor

Hi folks, the CLA check is passing. The code needs to be reviewed presumably by @priyakasimbeg (or anyone else in wg-algorithms). Note the message after the previous comment, " init-22 dismissed priyakasimbeg’s stale review via 76b084b 2 hours ago".

@priyakasimbeg
Copy link
Contributor

Hi Isaac can you run yapf -i -r -vv -p scoring/score_submissions.py to fix the yapf test and push the changes. Typically, we want to make PRs to the dev branch but I think this score_submissions.py file is out of sync with def and has a formatting error that is blocking this PR

@priyakasimbeg
Copy link
Contributor

This branch should also be synced with dev, which will fix the yapf tests.

priyakasimbeg
priyakasimbeg previously approved these changes Nov 22, 2024
@init-22 init-22 dismissed priyakasimbeg’s stale review November 22, 2024 18:15

The merge-base changed after approval.

@priyakasimbeg priyakasimbeg self-requested a review December 4, 2024 19:48
@priyakasimbeg priyakasimbeg merged commit 9d37d3e into mlcommons:dev Dec 4, 2024
16 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants