Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Controls #1617

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Image Controls #1617

wants to merge 5 commits into from

Conversation

EricBAndrews
Copy link
Member

@EricBAndrews EricBAndrews commented Jan 17, 2025

Checklist

  • I have read CONTRIBUTING.md
  • I have described what this PR contains
  • If this PR alters the UI, I have attached pictures/videos
  • This PR addresses one or more open issues that were assigned to me:
    - closes #issue
    - progress towards #issue

Pull Request Information

Replaces the image viewer context menu with a control layer.

Intended behavior:

  • Control layer is shown when viewer first opens
  • For non-animated media: control layer appears/disappears on tap
  • For animated media:
    • When playing: control layer appears/disappears on tap outside of media's frame (i.e., in the black margins)
    • When not playing: control layer appears/disappears on tap anywhere but the play button

This PR also removes the ProgressView from AnimationControlLayer. Media loading is almost always fast enough that the ProgressView is just visual clutter, and in rare cases a gif advertises itself as "animated" but isn't and leaves the ProgressView spinning on top of it (I don't have a repro example handy, but I have seen it a couple times).

@EricBAndrews EricBAndrews requested a review from a team as a code owner January 17, 2025 22:13
@EricBAndrews EricBAndrews requested review from Sjmarf and removed request for a team January 17, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant