Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit hooks and Github action for linting and formatting #16

Merged
merged 4 commits into from
Mar 12, 2024

Conversation

Wiebke
Copy link
Member

@Wiebke Wiebke commented Mar 11, 2024

Adds the same pre-commit hooks and actions as [mlexchange/mlex_highres_segmentation/168].(mlexchange/mlex_highres_segmentation#168)

Wiebke added 2 commits March 11, 2024 19:28
Manual fixes:
E501 line too long
src/seg_utils.py:14:5: F841 local variable 'first_data' is assigned to but never used
src/network.py:22:42: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
@Wiebke Wiebke requested review from TibbersHao and taxe10 March 11, 2024 19:34
Copy link
Member

@TibbersHao TibbersHao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. I have no objection of merging this to main.

@TibbersHao TibbersHao merged commit 89957dd into mlexchange:main Mar 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants