Fixed Python Notebook Examples #226

MarkFischinger · 2024-04-10T13:31:59Z

I'm excited to share some updates I've made to the Python notebook examples. While browsing through the existing examples because of #224, I noticed a few issues that had to be fixed.
Along with correcting typos, updating for the latest mlpack API changes as well as some other bug fixes, I've ensured all python notebooks are now fully functional by running and fixing each one :)

Once I have some more time, I plan to extend these fixes to the notebooks in other languages too.

review-notebook-app · 2024-04-10T13:32:04Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

github-actions · 2024-04-10T13:32:12Z

👈 Launch a binder notebook on branch MarkFischinger/examples/fix/examples

review-notebook-app · 2024-04-11T13:36:10Z

View / edit / reply to this conversation on ReviewNB

rcurtin commented on 2024-04-11T13:36:09Z
----------------------------------------------------------------

It seems like meanDates isn't used anywhere else (correct me if I'm wrong), maybe we can just remove this cell?

rcurtin · 2024-04-11T13:36:11Z

breast_cancer_wisconsin_transformation_with_pca/breast-cancer-wisconsin-pca-py.ipynb

@@ -1,175 +1,552 @@
 {


If you had any issues, I can put the CSV also on datasets.mlpack.org. Looks like maybe there was an SSL failure? But everything seems to load correctly for me.

Reply via ReviewNB

I put it up on https://datasets.mlpack.org/breast-cancer-wisconsin.csv, which shouldn't have an SSL issue, want to update the link to there?

rcurtin · 2024-04-11T13:36:12Z

contact_tracing_clustering_with_dbscan/contact_tracing_dbscan_py.ipynb

@@ -0,0 +1,506 @@
+{


Did you mean to add this notebook? It looks new, I guess an adaptation of the C++ version?

Reply via ReviewNB

@rcurtin yes, I thought it would be a great addition since most of the notebook examples have a C++ and Python version.

review-notebook-app · 2024-04-11T13:36:13Z

View / edit / reply to this conversation on ReviewNB

rcurtin commented on 2024-04-11T13:36:13Z
----------------------------------------------------------------

I just saw Whiplash a few weeks ago (number 24 on the list), I didn't realize it was so old. I thought it was a great movie.

MarkFischinger commented on 2024-04-11T15:03:55Z
----------------------------------------------------------------

Haven't seen it yet, but I’ll definitely check it out on your recommendation when I have the chance ;)

review-notebook-app · 2024-04-11T13:36:15Z

View / edit / reply to this conversation on ReviewNB

rcurtin commented on 2024-04-11T13:36:14Z
----------------------------------------------------------------

Nice catch!

review-notebook-app · 2024-04-11T13:36:16Z

View / edit / reply to this conversation on ReviewNB

rcurtin commented on 2024-04-11T13:36:16Z
----------------------------------------------------------------

I wonder if it would be possible to use mlpack.preprocess_split() and mlpack.preprocess_scale() here instead, but, don't feel obligated to look into it, it's just a passing thought.

rcurtin

Wow, this is absolutely great! Thank you for taking the time to go through all of these @MarkFischinger. I wish that we had an automated way to keep things up to date, but I think we don't have any CI job that tests the notebooks. All of my comments are pretty minor, really the main one is about the SSL verification---I think it shouldn't be needed, was there a certificate issue?

MarkFischinger · 2024-04-11T14:51:44Z

@rcurtin Yes, I encountered a slight issue with SSL verification while requesting lab.mlpack.org. The error I ran into was: URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1007)>.

My current approach is a workaround to this problem. However, I agree that the ideal solution would be to update the SSL certificate on the website.

MarkFischinger · 2024-04-11T15:03:56Z

Haven't seen it yet, but I’ll definitely check it out on your recommendation when I have the chance ;)

View entire conversation on ReviewNB

rcurtin · 2024-04-22T20:40:42Z

cifar10_transformation_with_pca/cifar-10-pca-py.ipynb

@@ -1,225 +1,666 @@
 {


Line #2. !wget --no-check-certificate -O - https://lab.mlpack.org/data/cifar10-images.tar.gz | tar -xz
This one can also be changed to https://datasets.mlpack.org/cifar10-images.tar.gz (actually it was already located there too).

Reply via ReviewNB

rcurtin · 2024-04-22T20:40:43Z

forest_covertype_prediction_with_random_forests/covertype-rf-py.ipynb

@@ -1,146 +1,171 @@
 {


Line #3. df = pd.read_csv('https://lab.mlpack.org/data/covertype-small.csv.gz')
Here you can use https://datasets.mlpack.org/covertype-small.csv.gz

Reply via ReviewNB

review-notebook-app · 2024-04-22T20:40:45Z

View / edit / reply to this conversation on ReviewNB

rcurtin commented on 2024-04-22T20:40:44Z
----------------------------------------------------------------

This is also on datasets.mlpack.org: https://datasets.mlpack.org/MovieLens-small.zip

rcurtin · 2024-04-22T20:41:15Z

I went through and added the datasets to datasets.mlpack.org, so now we can use that instead to avoid the SSL error. Can you make those changes? If so I think this is good to go. 👍

MarkFischinger · 2024-04-22T22:28:56Z

@rcurtin I removed all SSL certificate exceptions, tested it, and everything seems to be working fine now :)

rcurtin

Looks great, thanks again! 👍

mlpack-bot

Second approval provided automatically after 24 hours. 👍

rcurtin · 2024-05-01T11:29:25Z

Thanks again @MarkFischinger! 👍

MarkFischinger added 14 commits April 9, 2024 23:13

fix: python avocado

3b1bb72

fix: breast cancer wisconsin pca

5ac1948

fix: california housing

b385a97

fix: cifar 10 pca

6f838d6

feat: added missing contact tracing dbscan for python

ed6ff69

fix: customer personality clustering

701780f

fix: covertype rf

3fdb4e8

fix: graduate admission classification with adaboost

3cd48d5

fix: iris classification

2d38ccd

fix: movie lens cf

7d4eead

fix: rain in australia classification

8a8e238

fix: rainfall prediction with random forest

7fb6219

fix: salary predicition linear regression

3db596d

fix: typo

c590d33

mlpack-bot bot added s: needs review s: unanswered s: unlabeled labels Apr 10, 2024

rcurtin reviewed Apr 11, 2024

View reviewed changes

removed: meanDates

50ae08e

rcurtin removed the s: unlabeled label Apr 12, 2024

rcurtin added c: examples notebook and removed s: unanswered labels Apr 12, 2024

rcurtin reviewed Apr 22, 2024

View reviewed changes

MarkFischinger added 4 commits April 23, 2024 00:17

update ssl breast cancer wisconsin pca

fdea9e5

update ssl: covertype rf

63cd92e

update ssl: cifar 10 pca

8304624

update ssl: movie lens cf

7f5f52f

rcurtin approved these changes Apr 29, 2024

View reviewed changes

mlpack-bot bot approved these changes Apr 30, 2024

View reviewed changes

mlpack-bot bot removed the s: needs review label Apr 30, 2024

rcurtin merged commit 5b2062c into mlpack:master May 1, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed Python Notebook Examples #226

Fixed Python Notebook Examples #226

MarkFischinger commented Apr 10, 2024

review-notebook-app bot commented Apr 10, 2024

github-actions bot commented Apr 10, 2024

review-notebook-app bot commented Apr 11, 2024 •

edited

Loading

rcurtin Apr 11, 2024 •

edited

Loading

rcurtin Apr 22, 2024

rcurtin Apr 11, 2024 •

edited

Loading

MarkFischinger Apr 11, 2024

review-notebook-app bot commented Apr 11, 2024 •

edited

Loading

review-notebook-app bot commented Apr 11, 2024 •

edited

Loading

review-notebook-app bot commented Apr 11, 2024 •

edited

Loading

rcurtin left a comment

MarkFischinger commented Apr 11, 2024

MarkFischinger commented Apr 11, 2024

rcurtin Apr 22, 2024 •

edited

Loading

rcurtin Apr 22, 2024 •

edited

Loading

review-notebook-app bot commented Apr 22, 2024 •

edited

Loading

rcurtin commented Apr 22, 2024

MarkFischinger commented Apr 22, 2024

rcurtin left a comment

mlpack-bot bot left a comment

rcurtin commented May 1, 2024

Fixed Python Notebook Examples #226

Fixed Python Notebook Examples #226

Conversation

MarkFischinger commented Apr 10, 2024

review-notebook-app bot commented Apr 10, 2024

github-actions bot commented Apr 10, 2024

review-notebook-app bot commented Apr 11, 2024 • edited Loading

rcurtin Apr 11, 2024 • edited Loading

Choose a reason for hiding this comment

rcurtin Apr 22, 2024

Choose a reason for hiding this comment

rcurtin Apr 11, 2024 • edited Loading

Choose a reason for hiding this comment

MarkFischinger Apr 11, 2024

Choose a reason for hiding this comment

review-notebook-app bot commented Apr 11, 2024 • edited Loading

review-notebook-app bot commented Apr 11, 2024 • edited Loading

review-notebook-app bot commented Apr 11, 2024 • edited Loading

rcurtin left a comment

Choose a reason for hiding this comment

MarkFischinger commented Apr 11, 2024

MarkFischinger commented Apr 11, 2024

rcurtin Apr 22, 2024 • edited Loading

Choose a reason for hiding this comment

rcurtin Apr 22, 2024 • edited Loading

Choose a reason for hiding this comment

review-notebook-app bot commented Apr 22, 2024 • edited Loading

rcurtin commented Apr 22, 2024

MarkFischinger commented Apr 22, 2024

rcurtin left a comment

Choose a reason for hiding this comment

mlpack-bot bot left a comment

Choose a reason for hiding this comment

rcurtin commented May 1, 2024

review-notebook-app bot commented Apr 11, 2024 •

edited

Loading

rcurtin Apr 11, 2024 •

edited

Loading

rcurtin Apr 11, 2024 •

edited

Loading

review-notebook-app bot commented Apr 11, 2024 •

edited

Loading

review-notebook-app bot commented Apr 11, 2024 •

edited

Loading

review-notebook-app bot commented Apr 11, 2024 •

edited

Loading

rcurtin Apr 22, 2024 •

edited

Loading

rcurtin Apr 22, 2024 •

edited

Loading

review-notebook-app bot commented Apr 22, 2024 •

edited

Loading