CA APItest issue hunt

mmertama · Mar 19, 2024 · de31ca7 · de31ca7
1 parent 05bb9c1
commit de31ca7
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 2 deletions.
diff --git a/gempyrelib/include/gempyre.h b/gempyrelib/include/gempyre.h
@@ -457,11 +457,14 @@ namespace Gempyre {
         /// test if Element can be accessed. Note that in false it's may be in HTML, but not available in DOM tree.
         bool available(const std::string& id) const; 
 
+
         /// @cond INTERNAL
         // for testing
         void resume();
         // for testing
         void suspend();
+        // for testing 
+        bool ui_available() const;
         /// @endcond
 
     private:

diff --git a/gempyrelib/src/core.cpp b/gempyrelib/src/core.cpp
@@ -519,3 +519,7 @@ void Ui::flush() {
     m_ui->shoot_requests();
 }
 
+ bool Ui::ui_available() const {
+    return m_ui->is_connected() && m_ui->is_running();
+ }
+
diff --git a/gempyrelib/src/utils.cpp b/gempyrelib/src/utils.cpp
@@ -968,6 +968,7 @@ int GempyreUtils::execute(const std::string& executable, const std::string& para
         return static_cast<int>((hi > 32 || hi < 0) ? 0 : hi); //If the function succeeds, it returns a value greater than 32. If the function fails, it returns an error value that indicates the cause of the failure.
     }
 #else
+    std::cout << std::endl; // flush
     return std::system((executable + " " + parameters + " &").c_str());
 #endif
 }

diff --git a/test/apitests/gempyre_test.cpp b/test/apitests/gempyre_test.cpp
@@ -132,7 +132,7 @@ void TestUi::SetUp() {
         });
         const auto wait_start = GempyreUtils::wait_expire(30s, []() {
             GempyreUtils::log(GempyreUtils::LogLevel::Error, "Chrome not start");
-            FAIL() << "Chrome not start!";
+            FAIL() << "Chrome not start!" << " ui:" << (m_ui->ui_available() ? "ok" : "nok");
             std::exit(2);
             });
         m_ui->on_open([wait_start](){

diff --git a/test/apitests/mock_tests.cpp b/test/apitests/mock_tests.cpp
@@ -24,7 +24,7 @@ constexpr auto WaitExpireTimeout = 10s;
 
 
 //#define HANDLE_EXPIRE ui.exit()
-#define HANDLE_EXPIRE std::abort()
+#define HANDLE_EXPIRE FAIL() << "Chrome not start!" << " ui:" << (ui.ui_available() ? "ok" : "nok"); std::abort();
 
 TEST(TestMockUi, openPage_with_page_browser) {
     constexpr auto htmlPage = TEST_HTML;
-Original file line number
+Diff line change
@@ Expand Up @@
             return static_cast<int>((hi > 32 || hi < 0) ? 0 : hi); //If the function succeeds, it returns a value greater than 32. If the function fails, it returns an error value that indicates the cause of the failure.
         }
     #else
+        std::cout << std::endl; // flush
         return std::system((executable + " " + parameters + " &").c_str());
     #endif
     }
@@ Expand Down @@