Fixing compile issues in Linux, adding CMake #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lly different. Therefore, we must enable/disable operator<<() overloads using std::enable_if<>
…into other projects as a subdirectory/submodule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mmorearty ,
Thank you for publishing a very useful streamprintf library! It's amazingly handy when one needs to quickly redirect printf() in legacy code for internal processing.
I would like to offer some simple fixes to use your library in modern times. The most significant issue is that 'long' and 'int' are usually same only in Windows. Other fixes silence some GCC warnings. Finally, I add CMake file to 'include' your library into software builds managed by CMake.