Correction of the Disney BSDF #316
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I was quite annoyed by the mistakes that I found in the PBRT implementation of the Disney BSDF and corrected them. As I explained in #313 (comment) , having a specular transmission lobe turns out to be problematic since all different lobes are sampled with the same probability. Thus, if the ray is inside the material, every time there is a surface interaction most of the samples are wasted. In order to overcome this problem, I discarded the transmission lobe. Right now,
spec_transparameter is set0and discarded in3D(not thin) configuration.I also corrected the mistakes and compared the material model with Mitsuba by creating 20 renderings. They match.