ENH: Full mypy #1016
Merged
ENH: Full mypy #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before merging …
docs/source/vX.Y.md.inc)Final parts of
mypychecking. Some stuff is still disabled like:tests/configs/*-- I don't think we want to add a bunch of type annotations to these as they're meant to be more human / user-readablecontrib/*So I think this is the last set of changes needed for full mypy checking. Note that I created an
InFilesTwhich isdict[str, BIDSPath]and aInFilesPathT = dict[str, BIDSPath | Path]. The latter is used much less often, and typically just with FreeSurfer-facing steps. Not 100% sure I got which-is-which correct in all cases, but probably good enough for now.I also
git mv docs/source/v1.10.md.inc docs/source/dev.md.incbecause I always have totab-tabto find the correct version number when I need to change this doc. This adds burden to every PR where I have to read the list, figure out which (next) release version we're on, and change the correct doc. With the proposed change, this per-PR burden is gone: you always changedev.md.inc. The burden is changed to a one-time-per-release cost instead (as agit mvwill have to be performed there). Now our PR template can actually point to a specific file to change rather thanvX.Y.md.inc.