-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for MNE-ICALabel #812
base: main
Are you sure you want to change the base?
Conversation
@larsoner I'm not sure why this one test fails, could you help me out here please? :) |
|
It only looks for items that are |
Thanks @larsoner!! |
Also @hoechenberger we are almost through all of our 250,000 paid CircleCI compute credits for Nov mostly from MNE-BIDS-Pipeline usage (141,856 MBP vs 46,692 for MNE), so if there is any way you could push less often and do more local testing it would be greatly appreciated 🙏 |
Argh ok will try |
hey! I tried to merge the newest changes in mne_bids_pipeline into this branch to make use if icalabel - but it is more tricky than anticipated because quite some code got moved around and I am not familiar with the code-base. Any chance you have some newer local version already merged? If not, I will dig deeper into the code-base Cheerio! |
Hey @behinger, we did some serious refactoring of the ICA-related project organization. I believe it would be easier to start a new PR based off of the latest |
Okay, thanks for the response! We're (with @jschepers) looking into it :-) |
Before merging …
docs/source/changes.md
)