-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch build backend to hatchling #825
Conversation
pyproject.toml
Outdated
"/.*", | ||
"/codecov.yml", | ||
"**/tests", | ||
"/docs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ofek I'm explicitly excluding /docs
here, but /docs/source/examples/gen_examples.py
is still being packaged when I build the sdist. Any idea why that's happening? It's the only file in /docs
that gets packaged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah! There's an entry in .gitignore
:
!docs/source/examples/gen_examples.py
This explains it.
420fc3d
to
0762118
Compare
CI error due to packaging bug in MNE: forgot to include a file in the sdist Highlights that we should run out test suites on the installed packages and not on the checked-out repository. Cc @cbrnr |
See also mne-tools/mne-bids#1206 Cc @drammock |
Fixes packaging bug introduced in mne-tools#12269 Addresses the issues raised in: mne-tools/mne-bids-pipeline#825 (comment) mne-tools/mne-bids#1206 (comment) Ultimately, we should start testing the installed package(s), not simply fire up the tests from the root of the checked-out repo.
Fixes packaging bug introduced in mne-tools#12269 Addresses the issues raised in: mne-tools/mne-bids-pipeline#825 (comment) mne-tools/mne-bids#1206 (comment) Ultimately, we should start testing the installed package(s), not simply fire up the tests from the root of the checked-out repo.
@larsoner i think this is good to go |
Nice @hoechenberger ! |
* upstream/main: [pre-commit.ci] pre-commit autoupdate (mne-tools#830) [pre-commit.ci] pre-commit autoupdate (mne-tools#829) [pre-commit.ci] pre-commit autoupdate (mne-tools#828) [pre-commit.ci] pre-commit autoupdate (mne-tools#827) [pre-commit.ci] pre-commit autoupdate (mne-tools#826) Switch build backend to hatchling (mne-tools#825)
Before merging …
docs/source/changes.md
)cc @ofek in case you're interested :)