-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Document relevant steps #866
Conversation
Okay it was easier than I thought to parse the helper functions, ready for review/merge from my end @hoechenberger |
Also with this in place we should maybe rethink some of our categorization, for example Maybe it should live in the artifacts section. |
I will take a look at this shortly Thanks for your effort, Eric |
Co-authored-by: Richard Höchenberger <[email protected]>
{# START NEW CODE #} | ||
{% if pipeline_steps(attribute_name) %} | ||
{# https://squidfunk.github.io/mkdocs-material/reference/admonitions/#collapsible-blocks #} | ||
<details class="success"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tried this, but I'd prefer to use "info" instead of "success"
<details class="success"> | |
<details class="info"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I chose something other than info because that seemed to get a bit lost with the many other info blocks in our docs IIRC. Any others in here you like?
https://squidfunk.github.io/mkdocs-material/reference/admonitions/#collapsible-blocks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like these:
$ git grep "[!?+]\+ info" mne_bids_pipeline/_config.py | wc -l
26
So I wanted to differentiate / standardize using something else. Looks like note
isn't used so I'll try that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can also add our own admonitions (what a word … I'll never remember it correctly!)
https://squidfunk.github.io/mkdocs-material/reference/admonitions/?h=ad#custom-admonitions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure that would work, but we'd have to pick a color and icon. Maybe ✅ or 📋 icon? Actually abstract
standard type (which we don't use anywhere) already uses the clipboard icon so that could be nice.
And maybe all the Good practice / advice
that are currently info
should be changed to tip
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure that would work, but we'd have to pick a color and icon. Maybe ✅ or 📋 icon? Actually
abstract
standard type (which we don't use anywhere) already uses the clipboard icon so that could be nice.
I would also suggest to use the current "Abstract" icon – not a custom unicode one.
But really it's something we can also adjust at any later time, it's not a blocker for me right now!
Co-authored-by: Richard Höchenberger <[email protected]>
Okay I pushed with |
Before merging …
docs/source/changes.md
)Closes #862
Examples:
(I didn't realize
use_maxwell_filter
had a direct impact on the CSP step but it does because we pickmag
there if it's used!)Draft because I need to parse a few functions for
config
defs but that's a tiny detail -- the general idea and code is otherwise reviewable.