Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify maxfilter log message #991

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Conversation

drammock
Copy link
Member

@drammock drammock commented Sep 6, 2024

closes #985

Before merging …

  • Changelog has been updated (docs/source/changes.md)

@drammock
Copy link
Member Author

drammock commented Sep 6, 2024

WIP; TODO figure out why the other log message doesn't appear.

@drammock
Copy link
Member Author

drammock commented Sep 9, 2024

WIP; TODO figure out why the other log message doesn't appear.

Not sure what has changed, but the "Maxwell Filtering" log message does show up now on this branch. So this is ready for review.

@drammock drammock marked this pull request as ready for review September 9, 2024 19:49
@larsoner larsoner enabled auto-merge (squash) September 11, 2024 14:52
@larsoner larsoner merged commit 553e818 into mne-tools:main Sep 11, 2024
51 of 52 checks passed
@drammock drammock deleted the maxfilter-logging branch September 19, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logging order in maxfilter step is confusing
2 participants