Support preload=False for the new EEGLAB single .set format #13096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴 |
for more information, see https://pre-commit.ci
sappelhoff
reviewed
Feb 3, 2025
Comment on lines
+83
to
+84
| info_fields = [ | ||
| "setname", |
There was a problem hiding this comment.
Is there a list available (like an EEGLAB API documentation) that describes or at least simply but exhaustively enumerates these fields? If yes, it would be very valuable to link to that in a comment here, or in the docstr of the EEGLAB reading function. If not, I expect this bit of code to be relatively volatile, as we would always need an EEGLAB expert to help us fixing this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue (if any)
What does this implement/fix?
EEGLAB introduced a new mechanism that allows reading only metadata from a single .set file that has both data and metadata. Thus raw data no longer needed to be stored in a separate .fdt file. Adding this feature to MNE. This implementation uses scipy's loadmat and whosmat functions.
Additional information