Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates to reserve-auditor backend to build on MacOS #45

Merged
merged 8 commits into from
Feb 29, 2024
Merged

updates to reserve-auditor backend to build on MacOS #45

merged 8 commits into from
Feb 29, 2024

Conversation

holtzman
Copy link
Contributor

@holtzman holtzman commented Feb 28, 2024 •
edited
Loading

reserve-auditor rust backend wasn't building on MacOS any longer.

  • uprev to mobilecoin.git submodule to release/v6.0 most recent commit
  • uprev rust toolchain to nightly-2023-10-01 to match mobilecoin.git
  • uprev mbedtls, mbedtls-sys-auto and schnorrkel-og to match mobilecoin.git
  • clean up deprecated function call DateTime::from_utc(...) -> DateTime::from_naive_utc_and_offset(...)
  • clean up deprecated function call timestamp_nanos() -> timestamp_nanos_opt().unwrap()
  • comment out unused Cargo.toml [patch.crates-io] entries for curve25519-dalek, ed25519-dalek, and x25519-dalek
  • uprev curve25519-dalek to v4.1.1
  • canonicalize PartialOrd Impl for EthAddr
  • sort Cargo.toml to pass lint

@holtzman holtzman changed the title Uprev mobilecoin submodule commit, rust toolchain, and dependencies to build on MacOS [WiP]Uprev mobilecoin submodule commit, rust toolchain, and dependencies to build on MacOS Feb 28, 2024
@holtzman holtzman marked this pull request as draft February 28, 2024 02:15
@holtzman holtzman changed the title [WiP]Uprev mobilecoin submodule commit, rust toolchain, and dependencies to build on MacOS updates to reserve-auditor backend to build on MacOS Feb 28, 2024
@holtzman holtzman marked this pull request as ready for review February 28, 2024 08:34
nick-mobilecoin
nick-mobilecoin approved these changes Feb 28, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
src/convert/gnosis_safe_deposit.rs Outdated Show resolved Hide resolved
@holtzman holtzman merged commit 708f418 into main Feb 29, 2024
3 checks passed
@holtzman holtzman deleted the chore/uprev-apple-silicon branch February 29, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nick-mobilecoin nick-mobilecoin nick-mobilecoin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@holtzman @nick-mobilecoin