Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump melos #1032

Closed
wants to merge 3 commits into from
Closed

bump melos #1032

wants to merge 3 commits into from

Conversation

subzero911
Copy link
Contributor

Bump melos version to support Flutter 3.27.0

(small change)


Pull Request Checklist

  • If the changes are being made to code, ensure the version in pubspec.yaml is updated.
  • Increment the major/minor/patch/patch-count, depending on the complexity of change
  • Add the necessary unit tests to ensure the coverage does not drop
  • Update the Changelog to include all changes made in this PR, organized by version
  • Run the melos run set_version command from the root directory
  • Include the necessary reviewers for the PR
  • Update the docs if there are any API changes or additions to functionality

@pavanpodila
Copy link
Member

LGTM....seems to have a analysis issue ... once we fix that, we are good to merge @subzero911

@subzero911
Copy link
Contributor Author

CI/CD show the following error:
image

But it's not an unused parameter. It's nullable and shouldn't be initialized.

image

I think you should set your linter rules less strict instead.

@subzero911
Copy link
Contributor Author

unused_element is an analyser issue which is still open
dart-lang/sdk#54190

This reverts commit 400e590.
@subzero911
Copy link
Contributor Author

subzero911 commented Dec 16, 2024

@pavanpodila you merged PR #1033, but I didn't finish working on it
It doesn't solve the analysis issue

@subzero911 subzero911 closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants