Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

withBuildChild fix #1034

Merged
merged 8 commits into from
Dec 16, 2024
Merged

withBuildChild fix #1034

merged 8 commits into from
Dec 16, 2024

Conversation

subzero911
Copy link
Contributor

@subzero911 subzero911 commented Dec 16, 2024

I fixed Observer.withBuiltChild constructor.
I removed runtime asserts and unneeded nullables. So now it's neat.

I also added an example to the docs.


Pull Request Checklist

  • If the changes are being made to code, ensure the version in pubspec.yaml is updated.
  • Increment the major/minor/patch/patch-count, depending on the complexity of change
  • Add the necessary unit tests to ensure the coverage does not drop
  • Update the Changelog to include all changes made in this PR, organized by version
  • Run the melos run set_version command from the root directory
  • Include the necessary reviewers for the PR
  • Update the docs if there are any API changes or additions to functionality

Sergey Molchanovsky and others added 8 commits December 5, 2024 12:38
line len 80
Bumps [nanoid](https://github.com/ai/nanoid) from 3.3.7 to 3.3.8.
- [Release notes](https://github.com/ai/nanoid/releases)
- [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md)
- [Commits](ai/nanoid@3.3.7...3.3.8)

---
updated-dependencies:
- dependency-name: nanoid
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@subzero911
Copy link
Contributor Author

Sooo.
I fixed analysis options (which were spoiled in #1033 )
I also bumped melos right here.
Let's do it all in a single PR to not to get confused.

@pavanpodila pavanpodila merged commit d8ac087 into mobxjs:main Dec 16, 2024
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants