-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve third-party reporter docs #5285
docs: improve third-party reporter docs #5285
Conversation
@JoshuaKGoldberg this is ready for review, please let me know what I'm doing wrong with these darn compliance checks, I've read the verbose logs and I'm still confused! |
From https://github.com/mochajs/mocha/actions/runs/12599907071/job/35117787163?pr=5285:
Heh. Not exactly informative. I think this would be fixed by mtfoley/pr-compliance-action#368 -> mtfoley/pr-compliance-action#374. Anyway, it's that this doesn't "fix" an existing issue - just "works on". I edited the body now that the other PR is resolved. ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a couple of question/touchup points?
Co-authored-by: Josh Goldberg ✨ <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely, thanks :)
PR Checklist
status: accepting prs
Overview
Runner.constants
value used by reportersRunnable
classRunnable.prototype.xyz
calls are not published to the API doc site, leading to confusion about which properties are included in aRunnable
object, like aTest
or aHook
.