Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds filler response #24

Merged
merged 12 commits into from
Sep 18, 2024
Merged

Adds filler response #24

merged 12 commits into from
Sep 18, 2024

Conversation

erik-dunteman
Copy link
Collaborator

OPTIONAL feature add

Pros:

  • shaves off about 20% from the critical period latency (end of user speech to start of reply audio playback)
  • lightens the mood

Cons:

  • not a game-changing latency improvement
  • is one more component for users to engage with
  • users need to run a modal run src.fillers::Fillers.prefill command to activate this feature

@charlesfrye let's decide if this is worth it before I update docs.

@charlesfrye
Copy link
Collaborator

If it's optional, I say we keep it!

@charlesfrye
Copy link
Collaborator

Very fun addition, so let's stick with it!

@charlesfrye charlesfrye merged commit 1e01100 into modal-labs:main Sep 18, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants