Remove two unnecessary asserts, add logging

modcluster · Oct 24, 2023 · 29bdb85 · 29bdb85
1 parent cba3a0e
commit 29bdb85
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/native/mod_proxy_cluster/mod_proxy_cluster.c b/native/mod_proxy_cluster/mod_proxy_cluster.c
@@ -301,8 +301,7 @@ static apr_status_t create_worker_reuse(proxy_server_conf *conf, const char *ptr
     helper = *helper_ptr;
     if (helper->index == -1) {
         /* We are going to reuse a removed one */
-        ap_log_error(APLOG_MARK, APLOG_DEBUG, 0, server, "Created: reusing removed worker for %s", url);
-        ap_assert(0);
+        ap_log_error(APLOG_MARK, APLOG_NOTICE, 0, server, "create_worker_reuse: reusing removed worker for %s", url);
         return APR_SUCCESS;
     }
 
@@ -1287,8 +1286,10 @@ static int internal_update_lbstatus(proxy_server_conf *conf, apr_pool_t *pool, s
         strcmp(sport, ou->mess.Port)) {
         node_storage->unlock_nodes();
         /* the worker doesn't correspond to the node something is very broken */
-        ap_assert(0);
-        return 1; /* won't reach this one... */
+        ap_log_error(APLOG_MARK, APLOG_CRIT, 0, server,
+                     "update_workers_lbstatus worker: (%s) does not correspond to the node (%s)", worker->s->hostname,
+                     ou->mess.Host);
+        return 1;
     }
 
     /* Here we should decide about using hcheck result or a request that pings the node */