mod_proxy_cluster.c: Code tweaks and polishing, removal of two asserts #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jajik
changed the title
jfclere
reviewed
Oct 23, 2023
jfclere
reviewed
Oct 23, 2023
jajik
force-pushed
the
code-tweaks
branch
2 times, most recently
from
6493da3 to
6c112c6
Compare
Co-Authored-By: Jean-Frederic Clere <[email protected]>
jfclere
approved these changes
Nov 1, 2023
|
@jfclere Thank you, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some tweaks, I removed some unnecessary duplication, and removed once-used variables when it made sense. I also removed the two asserts that I think are unnecessary, but it would be better to double check it, I might miss something.