Add UseNocanon to mod_lbmethod_cluster, fix testsuite to use the right module
#302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jajik
force-pushed
the
issue-297
branch
4 times, most recently
from
b12c4d8 to
3fc8b9c
Compare
Do not run MODCLUSTER-734 for lbmethod_cluster as it does not work now See modcluster#301 for more info
jfclere
approved these changes
Nov 19, 2024
|
Thanks for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #297
close #298
This resolves two issues, but given that they are connected it seemed reasonable to do it at once. Test that ought to be run with balancer were unfortunately run with cluster. The testsuite needed a few changes and new conf files for the second module.