Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Use default configuration for tomcat containers #307

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

jajik
Copy link
Collaborator

@jajik jajik commented Dec 4, 2024

There is no reason to use non-default values.

@jajik jajik requested a review from rhusar December 4, 2024 13:17
advertise="false"
stickySession="true"
stickySessionForce="false"
stickySessionRemove="true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI - the stickySessionRemove is false by default. But clearly that's not tested anywhere here.

@rhusar rhusar merged commit f81683a into modcluster:main Dec 4, 2024
10 checks passed
@jajik jajik deleted the tomcat-defs branch December 4, 2024 13:27
@rhusar
Copy link
Member

rhusar commented Dec 4, 2024

Thanks @jajik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants