Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Standardize on 'Containerfile' naming and Upgrade to Fedora 41 #312

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

rhusar
Copy link
Member

@rhusar rhusar commented Jan 9, 2025

No description provided.

@rhusar
Copy link
Member Author

rhusar commented Jan 9, 2025

n.b. tests are broken in main - this PR doesn't touch that

@jajik
Copy link
Collaborator

jajik commented Jan 9, 2025

@rhusar Well, Github has updated Ubuntu image and broke stuff.

s/docker/moby-engine moby-cli/g

fixes it

@jajik
Copy link
Collaborator

jajik commented Jan 9, 2025

Also the step Stop Mono and XSP is not needed now.

(I wanted to make it part of another PR, but that's not ready yet, so feel free to change it in this one.)

@rhusar
Copy link
Member Author

rhusar commented Jan 9, 2025

Also the step Stop Mono and XSP is not needed now.

(I wanted to make it part of another PR, but that's not ready yet, so feel free to change it in this one.)

That's what included here yes.

@rhusar
Copy link
Member Author

rhusar commented Jan 9, 2025

@rhusar Well, Github has updated Ubuntu image and broke stuff.

s/docker/moby-engine moby-cli/g

fixes it

I don't want to use moby. I want to use podman... ;-)

@jajik
Copy link
Collaborator

jajik commented Jan 9, 2025

@

@rhusar Well, Github has updated Ubuntu image and broke stuff.
s/docker/moby-engine moby-cli/g
fixes it

I don't want to use moby. I want to use podman... ;-)

@rhusar we can use podman-docker instead, if it's such a big deal 😄 The PR is here if you're interested #313

@rhusar rhusar added this to the 2.0.0.Beta1 milestone Jan 9, 2025
Copy link
Collaborator

@jajik jajik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhusar rhusar merged commit 9924833 into modcluster:main Jan 10, 2025
10 checks passed
@rhusar rhusar deleted the containerfile branch January 10, 2025 10:32
@rhusar
Copy link
Member Author

rhusar commented Jan 10, 2025

Thanks @jajik for the review and fixup of the other job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants