Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add License annotation to external functions #4513

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

beutlich
Copy link
Member

@beutlich beutlich commented Dec 28, 2024

This PR comes along with #4411 (after merging Mo-2900) and makes the license texts of the external functions/objects explicit such that FMU exporting tools no longer need to distribute all files of modelica:/Modelica/Resources/Licenses/ along with the FMU, but only the actually used license texts.

Edit: Dependency on lapack (and the corresponding license texts) still is an exception since it is not seen as MSL dependency, but as tool requirement (see #2849).

Edit 2: Needs to be coordinated with #4240 and #4496.

@beutlich beutlich added the requires Modelica 3.7 Issue that requires Modelica Language Specification 3.7 label Dec 28, 2024
@beutlich beutlich changed the title Add license annotation to external functions Add License annotation to external functions Dec 28, 2024
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beutlich beutlich force-pushed the add-license-information-to-external-functions branch from 75f68ed to 9c05651 Compare January 2, 2025 16:54
Make license texts explicit.
@beutlich beutlich force-pushed the add-license-information-to-external-functions branch from 9c05651 to 25ae486 Compare January 15, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires Modelica 3.7 Issue that requires Modelica Language Specification 3.7
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants