Make propagation final of lifted parameters in Spring #4520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make propagation final of lifted parameter 'c' in Spring Fixes modelica#3707. * Make propagation final of lifted parameter 's_rel0' in Spring * Make propagation final of lifted parameters in Spring's lineForce component Even though the modification of lineShapeType is not parameter lifting, it would make little sense to make it non-final when all other modifications are final. * Make propagation of lifted parameter 'd' final in ModelicaTest example SpringDamperParallel --------- Co-authored-by: Anton Haumer <[email protected]> (cherry picked from commit a5cf0f3)
maltelenz
added
the
L: Mechanics.MultiBody
casella
approved these changes
Jan 21, 2025
HansOlsson
approved these changes
Jan 21, 2025
|
@casella I'm not authorized to merge to the maint branch, so please press the button (or anyone else who is allowed). |
|
I checked that they seem ok in MSL. Note that there is a hierarchical modifier for Spring's |
beutlich
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #4407 to 4.1.0.