Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct typing for TextWriter2d #210

Merged
merged 1 commit into from
Dec 22, 2024
Merged

Conversation

nocarryr
Copy link
Contributor

The pos argument for Textwriter2d's draw method is annotated as a 3-tuple:

def draw(self, pos: tuple[float, float, float], length: int = -1, size: float = 24.0) -> None:

It should be a 2-tuple according to its shader:

@einarf
Copy link
Member

einarf commented Dec 22, 2024

Thanks. that this was created in a hurry just to get some text going.

@einarf einarf merged commit 93349b9 into moderngl:master Dec 22, 2024
5 checks passed
@nocarryr nocarryr deleted the textwriter-typing branch December 22, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants