Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR-#5024: Make _row_lengths and _column_widths public #5025

Merged
merged 1 commit into from
Sep 25, 2022

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Sep 23, 2022

Signed-off-by: Myachev [email protected]

What do these changes do?

  • commit message follows format outlined here
  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves REFACTOR: make _row_lengths and _column_widths public #5024
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date
  • added (Issue Number: PR title (PR Number)) and github username to release notes for next major release

@anmyachev anmyachev marked this pull request as ready for review September 23, 2022 12:40
@anmyachev anmyachev requested review from a team as code owners September 23, 2022 12:40
@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Merging #5025 (98cf8fe) into master (90c57ff) will increase coverage by 4.69%.
The diff coverage is 94.11%.

❗ Current head 98cf8fe differs from pull request most recent head 4bac95e. Consider uploading reports for the commit 4bac95e to get more accurate results

@@            Coverage Diff             @@
##           master    #5025      +/-   ##
==========================================
+ Coverage   84.98%   89.67%   +4.69%     
==========================================
  Files         253      254       +1     
  Lines       19113    19396     +283     
==========================================
+ Hits        16243    17394    +1151     
+ Misses       2870     2002     -868     
Impacted Files Coverage Δ
...odin/core/storage_formats/pandas/query_compiler.py 96.40% <ø> (+0.55%) ⬆️
modin/experimental/xgboost/xgboost.py 87.61% <ø> (ø)
...me/pandas/interchange/dataframe_protocol/column.py 93.33% <50.00%> (ø)
modin/core/dataframe/pandas/dataframe/dataframe.py 95.23% <100.00%> (ø)
...pandas/interchange/dataframe_protocol/dataframe.py 96.72% <100.00%> (ø)
modin/logging/config.py 94.59% <0.00%> (-1.30%) ⬇️
modin/experimental/batch/test/test_pipeline.py 93.84% <0.00%> (ø)
modin/pandas/series.py 94.27% <0.00%> (+0.23%) ⬆️
modin/pandas/groupby.py 93.77% <0.00%> (+0.23%) ⬆️
modin/pandas/series_utils.py 98.89% <0.00%> (+0.55%) ⬆️
... and 39 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@mvashishtha mvashishtha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @anmyachev

@mvashishtha mvashishtha merged commit 1b8adb6 into modin-project:master Sep 25, 2022
@anmyachev anmyachev deleted the issue5024 branch September 25, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REFACTOR: make _row_lengths and _column_widths public
2 participants