Theseus Skin Manager #1277

Jakobabs · 2024-07-09T19:53:43Z

Adds a skin manager page to the app, where users can view/change their current skin, as well as store saved skins.

Resolves #415
Resolves #866

(Note the input search bar is broken across the whole app since monorepo change, and is not a skin manager issue
Edit: this has been fixed)

Made skin manager icon work with both light and dark (+ oled) themes.

MbtMarco · 2024-07-09T22:11:32Z

First of all thank you, I've been waiting for this feature for a long time.
I would like to suggest some improvements about your work.

Main skin manager window:

Regarding the main screen, I suggest you order "Add new skin" as the last one, in my opinion it makes more sense for it to be at the end.

Change skin window:

I suggest you leave a small empty space under "Cape" section

Also, if it is not already present, I suggest adding the possibility to change the cape without changing the skin. (Otherwise, if I only wanted to change the cape, I would have to create a new skin each time).

Lastly, I think it is redundant to use 3 different buttons for use, save and save+use. I think using the skin without saving it doesn't make much sense as the user can delete or modify it immediately afterwards anyway.

New skin: Cancel* | Upload (Means use+save)
Saved skin: Cancel* | Delete | Save | Re-Upload (Means save+use)

*Redundant as it is already present in the top right corner (the X could be replaced with the 'Cancel' buttom).

Jakobabs · 2024-07-10T02:01:14Z

Also, if it is not already present, I suggest adding the possibility to change the cape without changing the skin. (Otherwise, if I only wanted to change the cape, I would have to create a new skin each time).

I'll make it so the "add new skin" button autofills the current skin, so you can change the cape or arms and click upload.
The cancel buttons are on all modals in the app, so removing it would go against the current modal styling

@IntMarco Thank you for the feedback

SturdyFool10 · 2024-11-30T21:14:05Z

it would also be a great feature to make the capes display what they look like, only challenge I see with that though is making it not crash if, say, Mojank releases a new cape without Modrinth needing an update

Jakobabs · 2024-12-15T22:57:54Z

it would also be a great feature to make the capes display what they look like, only challenge I see with that though is making it not crash if, say, Mojank releases a new cape without Modrinth needing an update

Selecting a cape shows it in the 3d viewer

SturdyFool10 · 2024-12-24T04:24:59Z

absolutely awesome, all for it then, I just didn't want to be the guy who opens an enhancement a week after a feature gets added

# Conflicts: # Cargo.lock # pnpm-lock.yaml

…rinth#2388) Co-authored-by: Modrinth Bot <[email protected]>

Co-authored-by: Geometrically <[email protected]> Co-authored-by: Prospector <[email protected]>

…modrinth#3136) Co-authored-by: Jai Agrawal <[email protected]>

Co-authored-by: Jai Agrawal <[email protected]> Co-authored-by: Prospector <[email protected]>

…#3132) Co-authored-by: Jai Agrawal <[email protected]>

Resolves modrinth#1409

… are present (on the main mod page) (modrinth#3133) * feat: Automatically open download modal when filter queries are present * chore: Use a hash to open the modal, and make the filter queries independent of the modal

- Added min, max, and step fields to the input field of a slider - Made the input field a number field to apply min, max, step, and accessibility

* chore: run lint * fix: whoops messed up lint

…download modal use (modrinth#3138) * feat: Automatically open download modal when filter queries are present * chore: Use a hash to open the modal, and make the filter queries independent of the modal * chore: Correct to use emit for taking functions * chore: Add filter query and download hash to the url during modal use, and fix linting issues * chore(frontend): Undo changes to NewModal My computer does not like running the app, making testing a lot harder, so I'll undo this change, at least for now * Remove extra line --------- Signed-off-by: Prospector <[email protected]> Co-authored-by: Prospector <[email protected]>

* feat(frontend): tags link to a search * fix category type * process feedback --------- Co-authored-by: Prospector <[email protected]>

* Rough draft for fix for Mojang servers being down causing infinite installation * Add "pack installed" install step * Allow repairing an instance from Library to recover pack contents * Allow repair from instance page * Deduplicate repair code * Fix lint * Fix lint (for real this time) --------- Co-authored-by: Jai Agrawal <[email protected]>

* chore: show resubscribe on `failed` status Signed-off-by: Evan Song <[email protected]> * chore: hide cancel on failed Signed-off-by: Evan Song <[email protected]> * update copy Signed-off-by: Evan Song <[email protected]> --------- Signed-off-by: Evan Song <[email protected]>

* Fix typescript for OverflowMenu * Revert Discover content dropdown change to non-hoverable OverflowMenu * Lint

# Conflicts: # apps/app-frontend/src/App.vue

Prospector · 2025-01-16T00:30:18Z

Going to merge this into a branch on our repo to make working with it a bit easier. Thanks for your contribution!

Jakobabs and others added 22 commits February 3, 2024 17:08

initial skin manager commit; buggy and ugly

c959e98

Merge branch 'master' of https://github.com/Jakobabs/theseus

8cb3e04

Bug fixes and http request concurrency

9f8f838

Add to Library Feature

c8e7e55

Skin importer fix + curseforge support

2c4383a

skin-editor.svg now works across themes

acae587

partial custom ordering support

f2e1f1e

Merge branch 'Jakobabs:master' into master

8978cbc

Merge pull request #1 from MulesGaming/master

34b93f1

Made skin manager icon work with both light and dark (+ oled) themes.

Custom ordering support

431a582

Merge remote-tracking branch 'upstream/master'

4e0702c

Re-added auth refresh function

8e88178

updated skin manager to new auth

577e543

bug fixes

9ad71c0

now calls get_heads() after caching a new account

31c905d

Merge branch 'modrinth:master' into master

84a6734

removed unsafe unwrap when caching skins

f1c5fee

refactored variables

4ec2118

Loading skins icon css fix

7d5a81b

Merge remote-tracking branch 'upstream/main' into skin-manager

ab843b6

fix credential refresh

0304c5f

Skin Card filters stay after app restart

817360f

Jakobabs added 2 commits July 9, 2024 22:02

Cape/arms can now be changed without making a skin save

ca7e47a

refactor custom skin sorting

fdab47d

Jakobabs force-pushed the skin-manager branch from 077f6f6 to fdab47d Compare July 11, 2024 03:18

Jakobabs added 3 commits August 2, 2024 14:11

Merge remote-tracking branch 'upstream/main' into skin-manager

778672c

fixed code broken in merge

39afdd6

account heads now show the hat overlay

b041556

Norbiros mentioned this pull request Nov 30, 2024

Add the ability to change capes #2971

Open

2 tasks

Jakobabs added 2 commits December 15, 2024 14:54

Merge remote-tracking branch 'upstream/main' into skin-manager

48e8a66

Merge remote-tracking branch 'upstream/main' into skin-manager

6d43bb7

Prospector changed the base branch from main to app-skin-manager January 9, 2025 21:11

Prospector and others added 19 commits January 9, 2025 13:14

Merge remote-tracking branch 'origin/app-skin-manager' into skin-manager

5bd9743

# Conflicts: # Cargo.lock # pnpm-lock.yaml

Merge

90dbfee

Allow skipping updater at runtime with an environmental variable (mod…

021fee6

…rinth#2388) Co-authored-by: Modrinth Bot <[email protected]>

feat(app): update profile every time token is refreshed (modrinth#2328)

c52d5e9

Co-authored-by: Geometrically <[email protected]> Co-authored-by: Prospector <[email protected]>

Fix some text color issues. Remove experimental colors reset for now. (…

f859c34

…modrinth#3136) Co-authored-by: Jai Agrawal <[email protected]>

fix: an extra "2" after type "void" (modrinth#3127)

b2f4366

Co-authored-by: Jai Agrawal <[email protected]> Co-authored-by: Prospector <[email protected]>

fix: Properly handle empty version list on version/latest (modrinth…

fd9653e

…#3132) Co-authored-by: Jai Agrawal <[email protected]>

fix(frontend): lowercase giftcard sorting (modrinth#2986)

6266f29

Resolves modrinth#1409

Redesign Minecraft account selector

b5a1509

fix(ui): slider number input field with limits (modrinth#2899)

82f81dc

- Added min, max, and step fields to the input field of a slider - Made the input field a number field to apply min, max, step, and accessibility

chore: run lint (modrinth#3140)

494616e

* chore: run lint * fix: whoops messed up lint

feat(frontend): project tags link to a search (modrinth#3126)

abd679d

* feat(frontend): tags link to a search * fix category type * process feedback --------- Co-authored-by: Prospector <[email protected]>

Fix typescript for OverflowMenu (modrinth#3139)

e4cc8ef

* Fix typescript for OverflowMenu * Revert Discover content dropdown change to non-hoverable OverflowMenu * Lint

UI work

2f1e9fc

Merge branch 'main' into skin-manager

5e2bdab

# Conflicts: # apps/app-frontend/src/App.vue

Prospector marked this pull request as ready for review January 16, 2025 00:30

Prospector merged commit fc260b7 into modrinth:app-skin-manager Jan 16, 2025
1 of 2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Theseus Skin Manager #1277

Theseus Skin Manager #1277

Jakobabs commented Jul 9, 2024 •

edited

Loading

MbtMarco commented Jul 9, 2024 •

edited

Loading

Jakobabs commented Jul 10, 2024

SturdyFool10 commented Nov 30, 2024 •

edited

Loading

Jakobabs commented Dec 15, 2024

SturdyFool10 commented Dec 24, 2024 •

edited

Loading

Prospector commented Jan 16, 2025

Theseus Skin Manager #1277

Theseus Skin Manager #1277

Conversation

Jakobabs commented Jul 9, 2024 • edited Loading

MbtMarco commented Jul 9, 2024 • edited Loading

Main skin manager window:

Change skin window:

Jakobabs commented Jul 10, 2024

SturdyFool10 commented Nov 30, 2024 • edited Loading

Jakobabs commented Dec 15, 2024

SturdyFool10 commented Dec 24, 2024 • edited Loading

Prospector commented Jan 16, 2025

Jakobabs commented Jul 9, 2024 •

edited

Loading

MbtMarco commented Jul 9, 2024 •

edited

Loading

SturdyFool10 commented Nov 30, 2024 •

edited

Loading

SturdyFool10 commented Dec 24, 2024 •

edited

Loading