Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runtime): add loadEntry hook #2826

Merged
merged 22 commits into from
Aug 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/modern-suns-arrive.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@module-federation/runtime': minor
'@module-federation/sdk': patch
---

feat(runtime): add loadEntry hook
24 changes: 1 addition & 23 deletions packages/runtime/src/module/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,31 +30,9 @@ class Module {

// Get remoteEntry.js
const remoteEntryExports = await getRemoteEntry({
origin: this.host,
remoteInfo: this.remoteInfo,
remoteEntryExports: this.remoteEntryExports,
createScriptHook: (url: string, attrs: any) => {
const res = this.host.loaderHook.lifecycle.createScript.emit({
url,
attrs,
});

if (!res) return;

if (typeof document === 'undefined') {
//todo: needs real fix
return res as HTMLScriptElement;
}

if (res instanceof HTMLScriptElement) {
return res;
}

if ('script' in res || 'timeout' in res) {
return res;
}

return;
},
});
assert(
remoteEntryExports,
Expand Down
11 changes: 11 additions & 0 deletions packages/runtime/src/remote/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {
PreloadRemoteArgs,
Remote,
RemoteInfo,
RemoteEntryExports,
} from '../type';
import { FederationHost } from '../core';
import {
Expand Down Expand Up @@ -131,6 +132,16 @@ export class RemoteHandler {
options: Options;
origin: FederationHost;
}>(),
loadEntry: new AsyncHook<
[
{
createScriptHook: FederationHost['loaderHook']['lifecycle']['createScript'];
remoteInfo: RemoteInfo;
remoteEntryExports?: RemoteEntryExports;
},
],
Promise<RemoteEntryExports>
>(),
});

constructor(host: FederationHost) {
Expand Down
187 changes: 126 additions & 61 deletions packages/runtime/src/utils/load.ts
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
import {
composeKeyWithSeparator,
loadScript,
loadScriptNode,
CreateScriptHookReturn,
composeKeyWithSeparator,
isBrowserEnv,
} from '@module-federation/sdk';
import { assert } from '../utils/logger';
import { getRemoteEntryExports, globalLoading } from '../global';
import { Remote, RemoteEntryExports, RemoteInfo } from '../type';
import { DEFAULT_REMOTE_TYPE, DEFAULT_SCOPE } from '../constant';
import { FederationHost } from '../core';
import { globalLoading, getRemoteEntryExports } from '../global';
import { Remote, RemoteEntryExports, RemoteInfo } from '../type';
import { assert } from '../utils';

export async function loadEsmEntry({
async function loadEsmEntry({
entry,
remoteEntryExports,
}: {
Expand All @@ -33,7 +34,7 @@ export async function loadEsmEntry({
});
}

export async function loadSystemJsEntry({
async function loadSystemJsEntry({
entry,
remoteEntryExports,
}: {
Expand All @@ -57,7 +58,7 @@ export async function loadSystemJsEntry({
});
}

export async function loadEntryScript({
async function loadEntryScript({
name,
globalName,
entry,
Expand All @@ -66,10 +67,7 @@ export async function loadEntryScript({
name: string;
globalName: string;
entry: string;
createScriptHook?: (
url: string,
attrs?: Record<string, any> | undefined,
) => CreateScriptHookReturn;
createScriptHook: FederationHost['loaderHook']['lifecycle']['createScript'];
}): Promise<RemoteEntryExports> {
const { entryExports: remoteEntryExports } = getRemoteEntryExports(
name,
Expand All @@ -80,35 +78,99 @@ export async function loadEntryScript({
return remoteEntryExports;
}

if (typeof document === 'undefined') {
return loadScriptNode(entry, {
attrs: { name, globalName },
createScriptHook,
return loadScript(entry, {
attrs: {},
createScriptHook: (url, attrs) => {
const res = createScriptHook.emit({ url, attrs });

if (!res) return;

if (res instanceof HTMLScriptElement) {
return res;
}

if ('script' in res || 'timeout' in res) {
return res;
}

return;
},
})
.then(() => {
const { remoteEntryKey, entryExports } = getRemoteEntryExports(
name,
globalName,
);

assert(
entryExports,
`
Unable to use the ${name}'s '${entry}' URL with ${remoteEntryKey}'s globalName to get remoteEntry exports.
Possible reasons could be:\n
1. '${entry}' is not the correct URL, or the remoteEntry resource or name is incorrect.\n
2. ${remoteEntryKey} cannot be used to get remoteEntry exports in the window object.
`,
);

return entryExports;
})
.then(() => {
const { remoteEntryKey, entryExports } = getRemoteEntryExports(
name,
globalName,
);

assert(
entryExports,
`
Unable to use the ${name}'s '${entry}' URL with ${remoteEntryKey}'s globalName to get remoteEntry exports.
Possible reasons could be:\n
1. '${entry}' is not the correct URL, or the remoteEntry resource or name is incorrect.\n
2. ${remoteEntryKey} cannot be used to get remoteEntry exports in the window object.
`,
);

return entryExports;
})
.catch((e) => {
throw e;
});
.catch((e) => {
throw e;
});
}

async function loadEntryDom({
remoteInfo,
remoteEntryExports,
createScriptHook,
}: {
remoteInfo: RemoteInfo;
remoteEntryExports?: RemoteEntryExports;
createScriptHook: FederationHost['loaderHook']['lifecycle']['createScript'];
}) {
const { entry, entryGlobalName: globalName, name, type } = remoteInfo;
switch (type) {
case 'esm':
case 'module':
return loadEsmEntry({ entry, remoteEntryExports });
case 'system':
return loadSystemJsEntry({ entry, remoteEntryExports });
default:
return loadEntryScript({ entry, globalName, name, createScriptHook });
}
}

async function loadEntryNode({
remoteInfo,
createScriptHook,
}: {
remoteInfo: RemoteInfo;
createScriptHook: FederationHost['loaderHook']['lifecycle']['createScript'];
}) {
const { entry, entryGlobalName: globalName, name } = remoteInfo;
const { entryExports: remoteEntryExports } = getRemoteEntryExports(
name,
globalName,
);

if (remoteEntryExports) {
return remoteEntryExports;
}

return loadScript(entry, { attrs: {}, createScriptHook })
return loadScriptNode(entry, {
attrs: { name, globalName },
createScriptHook: (url, attrs) => {
const res = createScriptHook.emit({ url, attrs });

if (!res) return;

if ('url' in res) {
return res;
}

return;
},
})
.then(() => {
const { remoteEntryKey, entryExports } = getRemoteEntryExports(
name,
Expand Down Expand Up @@ -138,43 +200,46 @@ export function getRemoteEntryUniqueKey(remoteInfo: RemoteInfo): string {
}

export async function getRemoteEntry({
origin,
remoteEntryExports,
remoteInfo,
createScriptHook,
}: {
origin: FederationHost;
remoteInfo: RemoteInfo;
remoteEntryExports?: RemoteEntryExports | undefined;
createScriptHook?: (
url: string,
attrs?: Record<string, any> | undefined,
) => CreateScriptHookReturn;
}): Promise<RemoteEntryExports | void> {
const { entry, name, type, entryGlobalName } = remoteInfo;
}): Promise<RemoteEntryExports | false | void> {
jbroma marked this conversation as resolved.
Show resolved Hide resolved
const uniqueKey = getRemoteEntryUniqueKey(remoteInfo);
if (remoteEntryExports) {
return remoteEntryExports;
}

if (!globalLoading[uniqueKey]) {
if (['esm', 'module'].includes(type)) {
globalLoading[uniqueKey] = loadEsmEntry({
entry,
remoteEntryExports,
});
} else if (type === 'system') {
globalLoading[uniqueKey] = loadSystemJsEntry({
entry,
remoteEntryExports,
});
const loadEntryHook = origin.remoteHandler.hooks.lifecycle.loadEntry;
if (loadEntryHook.listeners.size) {
globalLoading[uniqueKey] = loadEntryHook
.emit({
createScriptHook: origin.loaderHook.lifecycle.createScript,
remoteInfo,
remoteEntryExports,
})
.then((res) => res || undefined);
} else {
globalLoading[uniqueKey] = loadEntryScript({
name,
globalName: entryGlobalName,
entry,
createScriptHook,
});
const createScriptHook = origin.loaderHook.lifecycle.createScript;
if (!isBrowserEnv()) {
globalLoading[uniqueKey] = loadEntryNode({
remoteInfo,
createScriptHook,
});
} else {
globalLoading[uniqueKey] = loadEntryDom({
remoteInfo,
remoteEntryExports,
createScriptHook,
});
}
}
}

return globalLoading[uniqueKey];
}

Expand Down
46 changes: 2 additions & 44 deletions packages/runtime/src/utils/preload.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,57 +80,15 @@ export function preloadAssets(
const module = host.moduleCache.get(remoteInfo.name);
if (module) {
getRemoteEntry({
origin: host,
remoteInfo: moduleInfo,
remoteEntryExports: module.remoteEntryExports,
createScriptHook: (url: string, attrs: any) => {
const res = host.loaderHook.lifecycle.createScript.emit({
url,
attrs,
});
if (!res) return;

if (typeof document === 'undefined') {
//todo: needs real fix
return res as HTMLScriptElement;
}

if (res instanceof HTMLScriptElement) {
return res;
}

if ('script' in res || 'timeout' in res) {
return res;
}

return;
},
});
} else {
getRemoteEntry({
origin: host,
remoteInfo: moduleInfo,
remoteEntryExports: undefined,
createScriptHook: (url: string, attrs: any) => {
const res = host.loaderHook.lifecycle.createScript.emit({
url,
attrs,
});
if (!res) return;

if (typeof document === 'undefined') {
//todo: needs real fix
return res as HTMLScriptElement;
}

if (res instanceof HTMLScriptElement) {
return res;
}

if ('script' in res || 'timeout' in res) {
return res;
}

return;
},
});
}
});
Expand Down
Loading
Loading