Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runtime): support publicPlugins throught options #3322

Conversation

yuvalkarif
Copy link

Description

Adds support for passing globalPlugins to the constructor, which registers them as global plugins.

Related Issue

Implements #3290

Types of Changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change that adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests have passed.
  • I have updated the documentation.

Additional Notes

I followed a similar approach to how regular plugins are handled, so I hope everything aligns correctly.

Regarding documentation, I can update it once the implementation gets approved. Additionally, should this MR include coverage for the framework's implementation? If needed, I’m happy to add that as well.

Copy link

changeset-bot bot commented Dec 5, 2024

⚠️ No Changeset found

Latest commit: 20aef52

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 20aef52
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/675b5788fdfe5400077dc932
😎 Deploy Preview https://deploy-preview-3322--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ScriptedAlchemy ScriptedAlchemy requested review from 2heal1 and zhoushaw and removed request for 2heal1 December 9, 2024 18:15
@ScriptedAlchemy
Copy link
Member

@yuvalkarif please run changeset add

@yuvalkarif yuvalkarif closed this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants