-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vue3-bridge): vue3-bridge parameter lossing issue #3462
Conversation
🦋 Changeset detectedLatest commit: 74de697 The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
const { moduleName, dom, basename, memoryRoute, ...propsInfo } = info; | ||
const app = Vue.createApp(bridgeInfo.rootComponent, propsInfo); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a small problem, I checked the file
packages/bridge/vue3-bridge/src/remoteApp.tsx
and it does not provide the moduleName
. It's just called name
there. This is actually a shared RenderFnParams
type problem. It seems that vue needs to write its own type or fix remoteApp.tsx
. What do you think?
I also did a small test and transferring props from vue to remoteApp didn't work, but I think I see where the problem is in the same file. But unfortunately, I don't have much time right now and I won't be able to create a PR until next week.
Description
fix(vue3-bridge): vue3-bridge parameter lossing issue
Related Issue
Types of changes
Checklist