Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue3-bridge): vue3-bridge parameter lossing issue #3462

Merged
merged 3 commits into from
Jan 26, 2025

Conversation

danpeen
Copy link
Contributor

@danpeen danpeen commented Jan 26, 2025

Description

fix(vue3-bridge): vue3-bridge parameter lossing issue

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

Copy link

changeset-bot bot commented Jan 26, 2025

🦋 Changeset detected

Latest commit: 74de697

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@module-federation/bridge-vue3 Patch
@module-federation/runtime Patch
@module-federation/enhanced Patch
@module-federation/rspack Patch
@module-federation/webpack-bundler-runtime Patch
@module-federation/sdk Patch
@module-federation/runtime-tools Patch
@module-federation/managers Patch
@module-federation/manifest Patch
@module-federation/dts-plugin Patch
@module-federation/third-party-dts-extractor Patch
@module-federation/devtools Patch
@module-federation/bridge-react Patch
@module-federation/bridge-shared Patch
@module-federation/bridge-react-webpack-plugin Patch
@module-federation/modern-js Patch
@module-federation/retry-plugin Patch
@module-federation/data-prefetch Patch
@module-federation/rsbuild-plugin Patch
@module-federation/error-codes Patch
@module-federation/inject-external-runtime-core-plugin Patch
@module-federation/nextjs-mf Patch
@module-federation/node Patch
@module-federation/storybook-addon Patch
@module-federation/modernjsapp Patch
@module-federation/esbuild Patch
@module-federation/runtime-core Patch
@module-federation/utilities Patch
website-new Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Jan 26, 2025

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit b600888
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/6795e4cf4f8eef00080b2f17
😎 Deploy Preview https://deploy-preview-3462--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zhoushaw zhoushaw merged commit f141396 into main Jan 26, 2025
17 checks passed
@zhoushaw zhoushaw deleted the fix/bridge-vue-props branch January 26, 2025 07:56
@KyrieLii KyrieLii mentioned this pull request Feb 7, 2025
Comment on lines +31 to +32
const { moduleName, dom, basename, memoryRoute, ...propsInfo } = info;
const app = Vue.createApp(bridgeInfo.rootComponent, propsInfo);
Copy link
Contributor

@Dell-it Dell-it Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a small problem, I checked the file
packages/bridge/vue3-bridge/src/remoteApp.tsx
and it does not provide the moduleName. It's just called name there. This is actually a shared RenderFnParams type problem. It seems that vue needs to write its own type or fix remoteApp.tsx. What do you think?


I also did a small test and transferring props from vue to remoteApp didn't work, but I think I see where the problem is in the same file. But unfortunately, I don't have much time right now and I won't be able to create a PR until next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants