Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bandit scan to github workflow #1834

Merged
merged 1 commit into from
Feb 2, 2025
Merged

Conversation

UlrichB22
Copy link
Collaborator

Used a customized copy of the action.yml from https://github.com/PyCQA/bandit-action.

The use of bandit-action was not possible because it uses Python 3.9. Reading the configuration in pyproject.toml requires an additional installation step for toml. This tool is integrated in Python since 3.11. If bandit-action raises the Python version, we can switch to bandit-action later.

Bandit results do not abort the workflow, it is terminated with success. The results are imported into the github security area using a sarif file. This area is protected and not publicly accessible. Tested with branch name 'test-github-action'.

image

@UlrichB22 UlrichB22 requested a review from RogerHaase January 30, 2025 15:37
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@RogerHaase RogerHaase merged commit 9cddd74 into moinwiki:master Feb 2, 2025
8 checks passed
@UlrichB22
Copy link
Collaborator Author

Fixes #1820.

@UlrichB22 UlrichB22 deleted the bandit_wf branch February 2, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants