-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(catalogue): Add city, latitude, longitude attributes to Organisations table #4602
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding semantics: DCAT uses foaf:Agent for organisations, which has subClass foaf:Organization, which has a property org:siteAddress https://www.w3.org/TR/vocab-org/#org:siteAddress, in which you can use geo locations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could fill these fields from the ROR automatically, so it's correct to apply them to all profiles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve, but if we move to ROR we might need to change it again.
ROR has: city name and id from geonames, lattitude and longitude, so this probably fits well |
Quality Gate passedIssues Measures |
What are the main changes you did
How to test
Questions