Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add type test #4651

Merged
merged 3 commits into from
Jan 30, 2025
Merged

chore: add type test #4651

merged 3 commits into from
Jan 30, 2025

Conversation

connoratrug
Copy link
Contributor

What are the main changes you did

  • explain what you changed and essential considerations.

How to test

  • explain here what to do to test this (or point to unit tests)

Checklist

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

@connoratrug connoratrug self-assigned this Jan 30, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
83.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

mswertz
mswertz approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@mswertz mswertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. In a future version we probably like a row of test data but lets now merge this first so we can use it :-)

@connoratrug connoratrug merged commit cb58246 into master Jan 30, 2025
7 checks passed
@connoratrug connoratrug deleted the chore/add-type-test branch January 30, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mswertz mswertz mswertz approved these changes

@DickPostma DickPostma Awaiting requested review from DickPostma

Assignees

@connoratrug connoratrug

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@connoratrug @mswertz