Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: components lib errors #4669

Closed
wants to merge 1 commit into from
Closed

fix: components lib errors #4669

wants to merge 1 commit into from

Conversation

connoratrug
Copy link
Contributor

  • fix typo's
  • remove console logs
  • fix multi root issues
  • fix rename issues
  • fix type issues

Closes #4666

What are the main changes you did

  • explain what you changed and essential considerations.

How to test

  • explain here what to do to test this (or point to unit tests)

Checklist

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

@connoratrug
fix: components lib errors
bd95077 
- fix typo's
- remove console logs
- fix multi root issues
- fix rename issues
- fix type issues

Closes #4666
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 3, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

chinook25
chinook25 requested changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@chinook25 chinook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InputBoolean clears its value when I try to select a value.
Sides of the InputTree checkboxes are missing (also broken on master).

mswertz
mswertz requested changes Feb 4, 2025
View reviewed changes
Copy link
Member

@mswertz mswertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please wait and instead review the #4664

@connoratrug
Copy link
Contributor Author

please wait and instead review the #4664
#4664 does not fix these issues

@connoratrug connoratrug requested a review from mswertz February 5, 2025 07:57
@connoratrug
Copy link
Contributor Author

outdated

@connoratrug connoratrug closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chinook25 chinook25 chinook25 requested changes

@davidruvolo51 davidruvolo51 Awaiting requested review from davidruvolo51

@mswertz mswertz Awaiting requested review from mswertz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Boolean radio not rendered
3 participants
@connoratrug @mswertz @chinook25