Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: feat/previews-to-aks #719

Merged
merged 31 commits into from
Oct 15, 2024
Merged

build: feat/previews-to-aks #719

merged 31 commits into from
Oct 15, 2024

Conversation

DickPostma
Copy link
Contributor

how to test:

  • Check If previews are deployed to Azure

todo:

  • updated docs in case of new feature
  • added tests

@DickPostma DickPostma requested a review from mswertz May 13, 2024 09:46
@DickPostma DickPostma self-assigned this May 13, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mswertz mswertz changed the title feat/previews-to-aks build: feat/previews-to-aks Sep 13, 2024
@@ -197,6 +203,14 @@ jobs:
docker images ls
docker compose rm

- run:
name: deploy preview to azure
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to be conditional on not being master.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a branche filter.
(Also inserted the function to delete the preview)

Master build could be implemented later on. I will make the build easier.. (Remove the docker tests, and test directly on the preview)

Copy link

@DickPostma DickPostma merged commit 41b5764 into master Oct 15, 2024
3 checks passed
@DickPostma DickPostma deleted the feat/previews-to-aks branch October 15, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants