Skip to content

Commit

Permalink
enable exclusive as reasonable default
Browse files Browse the repository at this point in the history
  • Loading branch information
svandenhaute committed Dec 20, 2024
1 parent 4500e23 commit aaa10fa
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions psiflow/execution.py
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,8 @@ def from_config(
provider_cls = SlurmProvider
provider_kwargs = kwargs.pop("slurm") # do not allow empty dict
provider_kwargs["init_blocks"] = 0
if not 'exclusive' in provider_kwargs:
provider_kwargs['exclusive'] = False
else:
provider_cls = LocalProvider # noqa: F405
provider_kwargs = kwargs.pop("local", {})
Expand Down

1 comment on commit aaa10fa

@svandenhaute
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message is misleading here and should say: disable exclusive as a reasonable default.

the exclusive=True default behavior of the Parsl SlurmProvider is avoided here by defaulting to exclusive=False, because this is a much more reasonable mode of operation.

Please sign in to comment.