Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing commits from MOM5 repo #9

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

aidanheerdegen
Copy link

@aidanheerdegen aidanheerdegen commented Sep 9, 2024

There were some commits added directly to the MOM5 repo src/shared sub-directory as part of other PRs.

mom-ocean/MOM5#351

mom-ocean/MOM5#361

This was a mistake, and to fix it these commits will be added to this FMS fork and then incorporated back into the MOM5 repo with a proper subtree update.

The changes in this commit are fairly innocuous. For the most part they remove non-standard and superfluous pre-processor comments on #endif commands.

There are also a couple of changes to support FORTRAN90 use mpi syntax in later versions of GCC, and to allow the use of a BOZ literal in a variable initialisation.

* Add uninitialised variables check to CI build
* Make optional preprocessor labels into comments
* gotm-4.0: Changed parameter to single precision to match call.
* Fixed some double ifdef defined preprocessor directives
* Removed all preprocessor comment like labels
* Undefine preprocessor types before reusing
* Fix formatting and update do/enddo in icarus.F90
* Rewrote deprecated arithmetic if statement for 20.04 compatibility
* Make init checks depend on setting DEBUG in build
* Only run debug compilation with non-atmosphere configs
* Added CMake build infrastructure for all non-ACCESS builds but EBM
* Added CMake dispatchable GitHub workflow
* Added CMake compile script
* Split update_version from version_compile script, so update could be called from any compile script
* Added MPI support for GCC >= 11
Copy link
Collaborator

@harshula harshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please update the subject and description of commits as appropriate to remove the unrelated dot points.

@aidanheerdegen aidanheerdegen merged commit e2dc2f4 into mom-ocean:master Sep 9, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants