changed to unit of of range reason

moment · Jan 6, 2024 · 14af2d2 · 14af2d2
1 parent 429c38e
commit 14af2d2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/src/impl/tokenParser.js b/src/impl/tokenParser.js
@@ -455,11 +455,12 @@ export function explainFromTokens(locale, input, format) {
       matches["h"] > 12 &&
       tokens.find((t) => t.val === "hh")
     ) {
+      const hourValue = matches["h"];
       return {
         input,
         tokens,
-        invalidReason: "unparsable",
-        invalidExplanation: "Can't parse 24-hour time with meridiem",
+        invalidReason: "unit out of range",
+        invalidExplanation: `you specified ${hourValue} (of type ${typeof hourValue}) as an hour along with a meridiem, which is invalid`,
       };
     }
     return { input, tokens, regex, rawMatches, matches, result, zone, specificOffset };

diff --git a/test/datetime/tokenParse.test.js b/test/datetime/tokenParse.test.js
@@ -21,8 +21,10 @@ test("DateTime.fromFormat() parses basic times", () => {
 test("DateTime.fromFormat() yields Invalid reason for invalid input", () => {
   const i = DateTime.fromFormat("11-08-2023 15:00 AM", "MM-dd-yyyy hh:mm a");
   expect(i.invalid).not.toBeNull();
-  expect(i.invalid.reason).toEqual("unparsable");
-  expect(i.invalid.explanation).toEqual("Can't parse 24-hour time with meridiem");
+  expect(i.invalid.reason).toEqual("unit out of range");
+  expect(i.invalid.explanation).toEqual(
+    "you specified 15 (of type number) as an hour along with a meridiem, which is invalid"
+  );
 });
 
 test("DateTime.fromFormat() throws ConflictingSpecificationError for invalid format", () => {