✨ Support multiple sources for a score #1480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afiune
reviewed
Nov 19, 2024
| @@ -966,10 +969,36 @@ message PurgeAssetsConfirmation { | |||
| map<string, string> errors = 2; | |||
| } | |||
|
|
|||
| // Sources is a list of sources. | |||
| // Used to get past marshal/unmarshal limitations of repeated Source fields. | |||
There was a problem hiding this comment.
Approaching this very naive; what limitation is that?
There was a problem hiding this comment.
You cannot call proto.Marshal(...) or unmarshal on a repeated ... field directly.
Signed-off-by: Christian Zunker <[email protected]>
czunker
force-pushed
the
czunker/extend_score_source
branch
from
b85a234 to
cf52d12
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.