🤖 Automatically create GH release after cnquery bump #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Zunker <[email protected]>
czunker
commented
Dec 19, 2024
.github/workflows/gh-release.yaml
Outdated
| tag_name: ${{ env.RELEASE_VERSION }} | ||
| generate_release_notes: true | ||
| make_latest: true | ||
| token: ${{ secrets.GH_BUILDER_TOKEN }} |
There was a problem hiding this comment.
I'm not sure about this token...
There was a problem hiding this comment.
As discussed:
I switched to the app token, as we already use it cnspec:
cnspec/.github/workflows/pr-test-lint.yml
Line 138 in 2b0dd2a
czunker
added a commit
to mondoohq/cnquery
that referenced
this pull request
Dec 19, 2024
This way, we can trigger a release in cnspec from this event. cnspec requires the cnquery container to do its own release. Related-to mondoohq/cnspec#1520 Signed-off-by: Christian Zunker <[email protected]>
|
This is based on the workflow we already use for the packer-plugin-release: https://github.com/mondoohq/packer-plugin-cnspec/blob/main/.github/workflows/gh-release.yaml |
czunker
commented
Dec 19, 2024
| workflow_dispatch: | ||
|
|
||
| env: | ||
| # C07QZDJFF89 == #release-coordination |
There was a problem hiding this comment.
Has the slack token privilege to write to this channel?
There was a problem hiding this comment.
yes, slack token has privileges for the whole org
Signed-off-by: Christian Zunker <[email protected]>
czunker
added a commit
to mondoohq/cnquery
that referenced
this pull request
Jan 7, 2025
This way, we can trigger a release in cnspec from this event. cnspec requires the cnquery container to do its own release. Related-to mondoohq/cnspec#1520 Signed-off-by: Christian Zunker <[email protected]>
Signed-off-by: Christian Zunker <[email protected]>
philipbalinov
approved these changes
Jan 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.