Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 simplify default provider install #868

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Conversation

arlimus
Copy link
Member

@arlimus arlimus commented Oct 20, 2023

Requires mondoohq/cnquery#2306

Uses provider IDs instead of other (confusing) means, after I finally cleaned up my original code.

Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification

@chris-rock chris-rock mentioned this pull request Oct 20, 2023
arlimus and others added 2 commits October 20, 2023 12:04
Requires mondoohq/cnquery#2306

Uses provider IDs instead of other (confusing) means, after I finally
cleaned up my original code.

Signed-off-by: Dominik Richter <[email protected]>
@chris-rock chris-rock force-pushed the dom/provider-install branch from 81c0ca9 to 12bf603 Compare October 20, 2023 10:05
@chris-rock chris-rock merged commit d4d56c3 into main Oct 20, 2023
8 checks passed
@chris-rock chris-rock deleted the dom/provider-install branch October 20, 2023 10:11
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants