Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Ensure that policy group checks are also properly cleaned if queries are missing #926

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

preslavgerchev
Copy link
Contributor

@preslavgerchev preslavgerchev commented Nov 2, 2023

We only were checking the queries part and not the checks, which mean that any policy grp w/o queries would have been skipped. Fixes #925

  • I want to add a test for this

@preslavgerchev preslavgerchev changed the title Ensure that policy group checks are also properly cleaned if queries are missing 🐛 Ensure that policy group checks are also properly cleaned if queries are missing Nov 2, 2023
Copy link
Contributor

@mariuskimmina mariuskimmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love to see the added test 👍

@vjeffrey vjeffrey merged commit 84d011b into main Nov 2, 2023
@vjeffrey vjeffrey deleted the preslav/925 branch November 2, 2023 17:15
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

asset filter in policy not working
3 participants