-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⭐ Add output handler to store asset reports #982
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preslavgerchev
force-pushed
the
preslav/sqs-report
branch
2 times, most recently
from
December 6, 2023 11:56
fb0dce2
to
aadf269
Compare
chris-rock
reviewed
Dec 6, 2023
preslavgerchev
force-pushed
the
preslav/sqs-report
branch
from
December 7, 2023 13:07
3fdc3aa
to
a4d967a
Compare
preslavgerchev
changed the title
⭐ Add remote reporter to send scan reports
⭐ Add output handler to store asset reports
Dec 7, 2023
preslavgerchev
force-pushed
the
preslav/sqs-report
branch
3 times, most recently
from
December 7, 2023 13:16
96482bb
to
7b84b78
Compare
chris-rock
reviewed
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice structured implementation. I am just having trouble to get the local file reporter running.
chris-rock
reviewed
Dec 11, 2023
chris-rock
reviewed
Dec 11, 2023
preslavgerchev
force-pushed
the
preslav/sqs-report
branch
2 times, most recently
from
December 14, 2023 17:13
8acdca5
to
fca5ca7
Compare
This currently only supports local files and AWS SQS topics. Signed-off-by: Preslav <[email protected]>
chris-rock
force-pushed
the
preslav/sqs-report
branch
from
December 20, 2023 11:35
fca5ca7
to
30f4758
Compare
chris-rock
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @preslavgerchev
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
--output-target
flag that specifies a target where the scan report can be stored.This currently only supports local files and AWS SQS urls. If no target is specified, it falls back to CLI reporting (which is the current default behaviour)
for AWS SQS reporting only
--output yaml
and--output json
are supported