SocksProxy: check for null socket in handler

Performs checks before dereferencing the handler's socket pointer.
monero-project · Aug 22, 2018 · 418ea8f · 418ea8f
1 parent 74dfd48
commit 418ea8f
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/src/client/proxy/socks.cc b/src/client/proxy/socks.cc
@@ -62,6 +62,12 @@ SOCKSHandler::SOCKSHandler(
         m_AddressType(IPv4),
         m_SOCKSVersion(SOCKS5),
         m_Command(Connect) {
+          if (!parent)
+            throw std::invalid_argument(
+                __func__ + std::string(": null server"));
+          if (!socket)
+            throw std::invalid_argument(
+                __func__ + std::string(": null socket"));
           m_Address.ip = 0;
           EnterState(GetSOCKSVersion);
         }