Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

AddressBook: move subscription saving to storage #1007

Closed
wants to merge 1 commit into from

Conversation

coneiric
Copy link
Contributor

@coneiric coneiric commented Aug 26, 2018

Save subscriptions based on type, and move I/O to AddressBookStorage. ~~~Makes the default hosts.txt read-only.~~~

Resolves #1006


By submitting this pull-request, I confirm the following:

  • I have read and understood the developer guide in kovri-docs.
  • I have checked that another pull-request for this purpose does not exist.
  • I have considered and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used and that this pull-request may be closed by the will of the maintainer.
  • I give this submission freely under the BSD 3-clause license.

Copy link
Collaborator

@anonimal anonimal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Save subscriptions based on type, and move I/O to AddressBookStorage.
@coneiric
Copy link
Contributor Author

coneiric commented Sep 6, 2018

From #1006-comment:

As I've said to you several times already, there is no plan to implement any PGP verification.

Removed it.

Note: the fix is much simpler

This also resolves the TODO in the code to move storage to the AddressBookStorage class. If you would like me to split the PR in two, I can.

@anonimal
Copy link
Collaborator

anonimal commented Sep 7, 2018

NOTICE: THIS PULL REQUEST HAS BEEN MOVED TO GitLab. Please reopen there if you wish to merge. See #1013 for details.

@anonimal anonimal closed this Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AddressBook: hosts.txt overwritten as a blank file
2 participants