Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Router: Change int to size_t #1008

Closed
wants to merge 1 commit into from
Closed

Router: Change int to size_t #1008

wants to merge 1 commit into from

Conversation

tmoravec
Copy link
Contributor

@tmoravec tmoravec commented Sep 2, 2018

Resolving an older TODO.

By submitting this pull-request, I confirm the following:

  • I have read and understood the developer guide in kovri-docs.
  • I have checked that another pull-request for this purpose does not exist.
  • I have considered and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used and that this pull-request may be closed by the will of the maintainer.
  • I give this submission freely under the BSD 3-clause license.

coneiric
coneiric suggested changes Sep 3, 2018
View reviewed changes
Copy link
Contributor

@coneiric coneiric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than one minor nitpick, changes look good to me.

src/core/router/garlic.cc Outdated Show resolved Hide resolved
@tmoravec
Router: Change int to size_t
49cb0c4 
Resolving an older TODO.
anonimal
anonimal suggested changes Sep 6, 2018
View reviewed changes
Copy link
Collaborator

@anonimal anonimal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tmoravec.

The TODO wasn't meant to clobber all related code. Realistically, we'll never need more than a count value of 2 bytes and most of the time we only need 1 byte. Feel free to fine-tune where needed.

@anonimal
Copy link
Collaborator

anonimal commented Sep 7, 2018

NOTICE: THIS PULL REQUEST HAS BEEN MOVED TO GitLab. Please reopen there if you wish to merge. See #1013 for details.

@anonimal anonimal closed this Sep 7, 2018
coneiric pushed a commit to coneiric/kovri that referenced this pull request Jan 23, 2019
@tmoravec
Router: Tags count to uint16_t
36113ca 
Resolving an older TODO.

Original Github PR: monero-project#1008
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anonimal anonimal anonimal requested changes

@coneiric coneiric coneiric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmoravec @anonimal @coneiric