This repository has been archived by the owner on Sep 1, 2022. It is now read-only.
SOCKS: unit-tests for the SOCKS implementation #1010
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes access restriction on SOCKS handler members to make them testable.
Performs checks before dereferencing the handler's socket pointer.
Merge one-line definitions with declarations in the header file.
On up-to-date Boost, all tests pass, and I lost access to Boost 1.58 boxes. ```
/home/vagrant/slave/kovri-all-ubuntu-amd64/build/tests/unit_tests/client/proxy/socks.cc:79:24: error: 'class boost::asio::const_buffers_1' has no member named 'data'
BOOST_CHECK(response.data());
``` |
|
NOTICE: THIS PULL REQUEST HAS BEEN MOVED TO GitLab. Please reopen there if you wish to merge. See #1013 for details. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull-request, I confirm the following:
Serves as a basis for evaluating the current SOCKS implementation, and progressing with future development.