Program options arg types and Bash completion #614

rakhimov · 2017-04-06T02:44:13Z

This additional information is helpful for deducing the hints.
Only bool and path arguments are added.
Adding type information with Boost program options
is verbose and repetitive due to lack of reflection.
Macros can help, but it is still ugly.

The refactoring removes
most hard-coded options in the completion script.
The suggestions are deduced from argument types (path, bool).

Issue #611

By submitting this pull-request, I confirm the following:

I have read and understood the Contributing Guide.
I have checked that another pull-request for this purpose does not exist.
I have considered and confirmed that this submission will be valuable to others.
I accept that this submission may not be used and that this pull-request may be closed by the will of the maintainer.
I give this submission freely under the BSD 3-clause license.

This additional information is helpful for deducing the hints. Only bool and path arguments are added. Adding type information with Boost program options is verbose and repetitive due to lack of reflection. Macros can help, but it is still ugly. Issue monero-project#611

The refactoring removes most hard-coded options in the completion script. The suggestions are deduced from argument types (path, bool). Issue monero-project#611.

anonimal

@rakhimov Very cool 👍

Referencing #610

838100a Packager: refactor bash completion with type info (rakhimov) 26fdddd Config: add cmd-line option argument type names (rakhimov)

rakhimov added 2 commits April 5, 2017 19:41

Packager: refactor bash completion with type info

838100a

The refactoring removes most hard-coded options in the completion script. The suggestions are deduced from argument types (path, bool). Issue monero-project#611.

anonimal approved these changes Apr 6, 2017

View reviewed changes

anonimal merged commit 838100a into monero-project:master Apr 6, 2017

anonimal added a commit that referenced this pull request Apr 6, 2017

Merge pull request #614

9b4eaa3

838100a Packager: refactor bash completion with type info (rakhimov) 26fdddd Config: add cmd-line option argument type names (rakhimov)

rakhimov deleted the bash-completion branch June 6, 2018 23:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Program options arg types and Bash completion #614

Program options arg types and Bash completion #614

rakhimov commented Apr 6, 2017 •

edited

Loading

anonimal left a comment

Program options arg types and Bash completion #614

Program options arg types and Bash completion #614

Conversation

rakhimov commented Apr 6, 2017 • edited Loading

anonimal left a comment

Choose a reason for hiding this comment

rakhimov commented Apr 6, 2017 •

edited

Loading